antanst/gemini-grc
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Clean up logging in worker processing

Browse Source 
- Move response code logging to happen after successful snapshot save
- Remove error message from log output for cleaner display
- Consolidate logging logic in saveSnapshotAndRemoveURL function
This commit is contained in:
antanst
2025-06-19 10:04:46 +03:00
parent acbac15c20
commit ee2076f337
1 changed files with 2 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
common/worker.go
View File

@@ -215,7 +215,6 @@ func WorkOnUrl(ctx context.Context, tx *sqlx.Tx, url string) (err error) {
} }
} }
contextlog.LogInfoWithContext(ctx, logging.GetSlogger(), "%2d", s.ResponseCode.ValueOrZero())
return saveSnapshotAndRemoveURL(ctx, tx, s) return saveSnapshotAndRemoveURL(ctx, tx, s)
} }
@@ -285,14 +284,14 @@ func saveSnapshotAndRemoveURL(ctx context.Context, tx *sqlx.Tx, s *snapshot.Snap
return err return err
} }
if shouldUpdateSnapshot { if shouldUpdateSnapshot {
contextlog.LogInfoWithContext(ctx, logging.GetSlogger(), "%2d %s", s.ResponseCode.ValueOrZero(), s.Error.ValueOrZero())
err := gemdb.Database.SaveSnapshot(ctx, tx, s) err := gemdb.Database.SaveSnapshot(ctx, tx, s)
if err != nil { if err != nil {
return err return err
} }
contextlog.LogInfoWithContext(ctx, logging.GetSlogger(), "%2d", s.ResponseCode.ValueOrZero())
return removeURL(ctx, tx, s.URL.String()) return removeURL(ctx, tx, s.URL.String())
} else { } else {
contextlog.LogInfoWithContext(ctx, logging.GetSlogger(), "%2d %s (but old content exists, updating crawl date)", s.ResponseCode.ValueOrZero(), s.Error.ValueOrZero()) contextlog.LogInfoWithContext(ctx, logging.GetSlogger(), "%2d (but old content exists, updating crawl date)", s.ResponseCode.ValueOrZero())
err = gemdb.Database.UpdateLastCrawled(ctx, tx, s.URL.String()) err = gemdb.Database.UpdateLastCrawled(ctx, tx, s.URL.String())
if err != nil { if err != nil {
return err return err