From ee2076f337b39637d08316849a6c43a3ae46e73b Mon Sep 17 00:00:00 2001 From: antanst <> Date: Thu, 19 Jun 2025 10:04:46 +0300 Subject: [PATCH] Clean up logging in worker processing - Move response code logging to happen after successful snapshot save - Remove error message from log output for cleaner display - Consolidate logging logic in saveSnapshotAndRemoveURL function --- common/worker.go | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/common/worker.go b/common/worker.go index 78d54ea..0e478d6 100644 --- a/common/worker.go +++ b/common/worker.go @@ -215,7 +215,6 @@ func WorkOnUrl(ctx context.Context, tx *sqlx.Tx, url string) (err error) { } } - contextlog.LogInfoWithContext(ctx, logging.GetSlogger(), "%2d", s.ResponseCode.ValueOrZero()) return saveSnapshotAndRemoveURL(ctx, tx, s) } @@ -285,14 +284,14 @@ func saveSnapshotAndRemoveURL(ctx context.Context, tx *sqlx.Tx, s *snapshot.Snap return err } if shouldUpdateSnapshot { - contextlog.LogInfoWithContext(ctx, logging.GetSlogger(), "%2d %s", s.ResponseCode.ValueOrZero(), s.Error.ValueOrZero()) err := gemdb.Database.SaveSnapshot(ctx, tx, s) if err != nil { return err } + contextlog.LogInfoWithContext(ctx, logging.GetSlogger(), "%2d", s.ResponseCode.ValueOrZero()) return removeURL(ctx, tx, s.URL.String()) } else { - contextlog.LogInfoWithContext(ctx, logging.GetSlogger(), "%2d %s (but old content exists, updating crawl date)", s.ResponseCode.ValueOrZero(), s.Error.ValueOrZero()) + contextlog.LogInfoWithContext(ctx, logging.GetSlogger(), "%2d (but old content exists, updating crawl date)", s.ResponseCode.ValueOrZero()) err = gemdb.Database.UpdateLastCrawled(ctx, tx, s.URL.String()) if err != nil { return err