antanst/gemini-grc
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix linter warnings in gemini/network.go

Browse Source 
Remove redundant nil checks before len() operations as len() for nil slices is defined as zero in Go.
This commit is contained in:
antanst
2025-03-10 11:33:56 +02:00
committed by antanst
parent 701a5df44f
commit a41490f834
2 changed files with 4 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
gemini/network.go
View File

@@ -17,7 +17,6 @@ import (
_url "gemini-grc/common/url" _url "gemini-grc/common/url"
"gemini-grc/config" "gemini-grc/config"
"gemini-grc/logging" "gemini-grc/logging"
"github.com/antanst/go_errors" "github.com/antanst/go_errors"
"github.com/guregu/null/v5" "github.com/guregu/null/v5"
) )
@@ -217,17 +216,17 @@ func getMimeTypeAndLang(headers string) (int, string, string) {
// - Only capturing the lang value, ignoring charset // - Only capturing the lang value, ignoring charset
re := regexp.MustCompile(`^(\d+)\s+([a-zA-Z0-9/\-+]+)(?:(?:[\s;]+(?:charset=[^;\s]+|lang=([a-zA-Z0-9-]+)))*)\s*$`) re := regexp.MustCompile(`^(\d+)\s+([a-zA-Z0-9/\-+]+)(?:(?:[\s;]+(?:charset=[^;\s]+|lang=([a-zA-Z0-9-]+)))*)\s*$`)
matches := re.FindStringSubmatch(headers) matches := re.FindStringSubmatch(headers)
if matches == nil || len(matches) <= 1 { if len(matches) <= 1 {
// If full format doesn't match, try to match redirect format: "<code> <URL>" // If full format doesn't match, try to match redirect format: "<code> <URL>"
// This handles cases like "31 gemini://example.com" // This handles cases like "31 gemini://example.com"
re := regexp.MustCompile(`^(\d+)\s+(.+)$`) re := regexp.MustCompile(`^(\d+)\s+(.+)$`)
matches := re.FindStringSubmatch(headers) matches := re.FindStringSubmatch(headers)
if matches == nil || len(matches) <= 1 { if len(matches) <= 1 {
// If redirect format doesn't match, try to match just a status code // If redirect format doesn't match, try to match just a status code
// This handles cases like "99" // This handles cases like "99"
re := regexp.MustCompile(`^(\d+)\s*$`) re := regexp.MustCompile(`^(\d+)\s*$`)
matches := re.FindStringSubmatch(headers) matches := re.FindStringSubmatch(headers)
if matches == nil || len(matches) <= 1 { if len(matches) <= 1 {
return 0, "", "" return 0, "", ""
} }
code, err := strconv.Atoi(matches[1]) code, err := strconv.Atoi(matches[1])

1
gopher/network.go
View File

@@ -17,7 +17,6 @@ import (
_url "gemini-grc/common/url" _url "gemini-grc/common/url"
"gemini-grc/config" "gemini-grc/config"
"gemini-grc/logging" "gemini-grc/logging"
"github.com/antanst/go_errors" "github.com/antanst/go_errors"
"github.com/guregu/null/v5" "github.com/guregu/null/v5"
) )